Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve classpath modules resolution #2360

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

adamretter
Copy link
Member

@adamretter adamretter commented Jan 3, 2019

Related to eXist-db/documentation#291

Fixes a bug whereby XQuery Modules executed from the classpath cannot import modules from the same relative classpath location.

@adamretter adamretter added the bug issue confirmed as bug label Jan 3, 2019
@adamretter adamretter added this to the eXist-5.0.0 milestone Jan 3, 2019
@adamretter adamretter changed the title [bugfix] Allow modules on the classpath to be resolved as siblings or… Improve classpath modules resolution Jan 3, 2019
duncdrum
duncdrum previously approved these changes Jan 3, 2019
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and happy new year adam

@duncdrum duncdrum dismissed their stale review January 3, 2019 10:16

win ci not happy

Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a potential security concern....

@dizzzz dizzzz merged commit 9c9168f into eXist-db:develop Jan 5, 2019
@adamretter adamretter deleted the module-classpath-relative branch January 5, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants